Fix issue with Element.visible reading only inline style. [closes #131

]
prototypejs · Apr 22, 2014 · 548580c · 548580c · yunosh · Jul 5, 2016
1 parent d9411e5
commit 548580c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/prototype/dom/dom.js b/src/prototype/dom/dom.js
@@ -290,7 +290,7 @@
    *      // -> true
   **/
   function visible(element) {
-    return $(element).style.display !== 'none';
+    return $(element).getStyle('display') !== 'none';
   }
 
   /**

diff --git a/test/unit/dom_test.js b/test/unit/dom_test.js
@@ -290,6 +290,10 @@ new Test.Unit.Runner({
   testElementVisible: function(){
     this.assertNotEqual('none', $('test-visible').style.display);
     this.assertEqual('none', $('test-hidden').style.display);
+
+    this.assert($('test-visible').visible());
+    this.assert(!$('test-invisible').visible());
+    this.assert(!$('test-hidden').visible());
   },
 
   testElementToggle: function(){

diff --git a/test/unit/fixtures/dom.html b/test/unit/fixtures/dom.html
@@ -2,7 +2,12 @@
   <p id="scroll_test_2">Scroll test</p>
 </div>
 
+<style type="text/css">
+  #test-invisible { display: none; }
+</style>
+
 <div id="test-visible">visible</div>
+<div id="test-invisible">invisible</div>
 <div id="test-hidden" style="display:none;">hidden</div>
 <div id="test-toggle-visible">visible</div>
 <div id="test-toggle-hidden" style="display:none;">hidden</div>