Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new method for Object class, Object #isObject #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajuGT
Copy link

@rajuGT rajuGT commented Mar 21, 2015

Short explanation why I added this API.

I wrote a function which can process the request with variable arguments
case A : arg0 -> property, arg1 -> value
or
case B : arg0 -> {properties : values}

So for the case (B), I need to make sure the param is only of type Object else the results will be odd.
Because in javascript for in loop can loop over string by creating properties 0, 1, 2... for each character the string contains and also over String class properties.

Also most of the utility functions we write takes options/params parameter, which is an object (mostly containing flags) to add additional functionality for any utility. So looping over the options/params will be error free, if we make sure the param is Object type.
This will also eliminates null check for options because if the parameter is null/undefined Object.isObject(null) returns false.

@savetheclocktower
Copy link
Collaborator

Hmm. Maybe.

Leaving this open for now so I can revisit it in a future version; next release will be a bugfix release.

@savetheclocktower
Copy link
Collaborator

Closing because we're removing support for IE 8 and below.

@savetheclocktower
Copy link
Collaborator

Whoops, wrong PR. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants