Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Carousel pause/play #1903

Closed
lukefretwell opened this issue Oct 25, 2021 · 5 comments
Closed

Accessibility: Carousel pause/play #1903

lukefretwell opened this issue Oct 25, 2021 · 5 comments

Comments

@lukefretwell
Copy link
Contributor

There is no way to pause, stop, or hide the carousel.
Recommend adding an accessible Pause/Play button. See W3C’s Carousel Concepts for help.

Comments

@kevindherman I'd recommend they not use the carousel if they're adamant about being 100% inclusive on all of the sections of the page. Pause/play is a must include, but in general carousels aren't great for accessibility.

Here's a great post related to this: https://thegood.com/insights/ecommerce-image-carousels/

@lukefretwell lukefretwell added this to the Accessibility (MC) milestone Oct 25, 2021
@lukefretwell lukefretwell added this to Backlog in proudcity/wp-proudcity via automation Oct 25, 2021
@kevindherman kevindherman moved this from Backlog to Immediate In Progress in proudcity/wp-proudcity Oct 26, 2021
@aschmoe
Copy link
Member

aschmoe commented Oct 28, 2021

This should be easy enough to add (though I agree with Luke):

LOE: 30 minutes

@kevindherman
Copy link

@aschmoe @lukefretwell I agree with not using the slider but this has become an increasingly popular item so I'd like to include the fix but please prioritize accordingly.

@kevindherman kevindherman moved this from To-do to Doing in proudcity/wp-proudcity Nov 8, 2021
@kevindherman kevindherman moved this from Doing to To-do in proudcity/wp-proudcity Nov 8, 2021
@kevindherman kevindherman moved this from Backlog to To do in ProudCity project board Nov 12, 2021
@lukefretwell
Copy link
Contributor Author

@aschmoe would be great to take care of #1725 if it's not too much extra work.

@aschmoe
Copy link
Member

aschmoe commented Dec 3, 2021

@kevindherman @lukefretwell bootstrap doesn't seem to have a pause button built in. I was able to add the slide controls but not sure that gets to the core of the request.

Screen Shot 2021-12-02 at 8 59 06 PM

@kevindherman
Copy link

@aschmoe that definitely helps. Please deploy when you get a chance.

@kevindherman kevindherman moved this from To do to Doing in ProudCity project board Jan 27, 2022
@aschmoe aschmoe moved this from Doing to QA in ProudCity project board Feb 11, 2022
@aschmoe aschmoe moved this from QA to Ready for release in ProudCity project board Feb 11, 2022
@jlyon jlyon mentioned this issue Feb 16, 2022
10 tasks
@jlyon jlyon changed the title Carousel pause/play Accessibility: Carousel pause/play Feb 16, 2022
@jlyon jlyon closed this as completed Feb 17, 2022
ProudCity project board automation moved this from Ready for release to Done Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants