-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong time displaying in calendar widget #2035
Comments
@curtismchale This is using https://wp-events-plugin.com/ with https://wordpress.org/plugins/wp-fullcalendar/. It looks like they might have another solution for calendars and we might not need the full-blown fullcalendar JS library (which is massive) for sites that want to show a calendar ( In Kevin's testing the culprit was definitely wp-rocket (he said that the datetimes were fixed when logged in once we disabled admin caching, but still broken for anon users). For https://www.santa-ana.org/library-calendar/, we might just be able to disable wp-rocket on that specific page (Kevin said that's the only page they're using fullcalendar on), but that probably won't scale as we rollout wp-rocket to everyone. |
looks like we could probably just init something like
up in the header or whatever. The offending code is coming from the plugin in |
@curtismchale though I am seeing on the Williams site:
which I'm not seeing in the markup on santa ana... so not sure whats up with that. |
Setting these Never cache urls on https://www.santa-ana.org/wp-admin/options-general.php?page=wprocket#advanced_cache didn't seem to fix it. |
Here's more details on the calendar options with wp-events-manager. The non-fullcalendar version looks pretty bad... https://wp-events-plugin.com/documentation/calendars/ |
@jlyon @curtismchale @aschmoe I'm looking at https://www.santa-ana.org/library-calendar/ and it's displaying the correct times. Could there just have been a delay? |
@curtismchale https://github.com/wp-plugins/wp-fullcalendar/blob/master/wp-fullcalendar.php#L145 this is what was missing from the dom in the full calendar case, fyi. |
After review we've resolved this with a change to the JS settings in WP Rocket. Everything appears to work fine now. |
Source
Santa Ana: https://www.santa-ana.org/library-calendar/
Describe the bug
The calendar widget displays the publish time rather than the event time in the calendar display. This seems isolated to Santa Ana which makes me believe it's a WP-Rocket setting.
View https://www.santa-ana.org/library-calendar/ and you'll see event times per event. If you click on one you'll notice a different time is displayed.
https://www.santa-ana.org/event/wilshire-square-neighborhood-meeting-wednesday-may-4/
If you edit the event you'll notice the time on the calendar is the time the event was published.
Expected behavior
If you look at an example without WP Rocket enabled the calendar times display correctly: https://www.williamsnd.com/calendar
Screenshots
Incorrect time display:
https://www.santa-ana.org/library-calendar/
Event shows correct time (different from calendar widget)
Time in the calendar widget matches published on time:
Correct display: https://www.williamsnd.com/calendar (not using wp-rocket)
The text was updated successfully, but these errors were encountered: