-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate specific job configurations and framework configurations #11
Comments
I have created
The contents of the branches, and how these differ from the original interoperability test harness, are as follows. Each branch contains a Python package that can be installed using
Default test harness configuration files are now located alongside the Python test harness files that read them e.g.
The Python files above look for these files in the same directory as the Python file itself. If a developer wants to use their own configuration file, they can either edit the file, or point to the location of their own one using an environment variable (this latter aspect was already supported in the original design). When
For
which loaded in a converter-specific test harness configuration file and used it to configure a converter's test class. This has been renamed to:
which returns the configuration. A new function allows sub-classes to configure the converter-specific test class using this configuration.
This has been introduced to allow developers to write their configuration in-code and configure their test class that way also without needing to use a configuration file at all prov_interop_provpy/interop_tests/test_provpy_hardcoded.py provides an example of an interop test class with hard-coded configuration.
I'm not sure how ProvToolbox could be installed directly from within the test framework (i.e. within Python) as, while it could be downloaded and unpackaged, the challenge is updating Returning to your requests:
Not done, beyond provision of a shell script, see above.
Done
Done
Done |
In the above, the repositories with the converter-specific extensions serve two roles:
A next step would be to migrate the .travis.yml content that runs the interop tests to yours' and Lucs' ProvPy and ProvToolbox .travis.yml jobs. These would then be responsible for the following:
This would mean that the responsibility for running the interop tests falls to your ProvPy/ProvToolbox repositories (after unit tests have all succeeded, for example), and would be triggered every time ProvPy/ProvToolbox commits are done, which would be more in the spirit of Travis. |
Improve the design of the harness framework so that:
On the second point, the framework currently provides the converter classes for ProvPy, ProvToolbox, ProvStore, and ProvTranslator. I think those should be moved to the corresponding job repos. By so doing, we will also provide examples for converters developed not by Southampton team how to take advantage of the interop test framework without the need to modify the test framework's code.
The text was updated successfully, but these errors were encountered: