Add an environment variable EMSCRIPTEN_ROOT for emscripten installed with brew and add supports for other wasm targets.
#276
Conversation
Use vcpkg-rs to manage z3 instead. A non-default feature vcpkg is added. However, vcpkg-rs does not support wasm32 target currently. I created a pull request there at mcgoo/vcpkg-rs#53
Make emscripten visible to wasm32-unknown-unknown if emscripten is installed.
Z3_HEADER_VAR will disappear when the feature vcpkg is enabled.
Use is_err instead of pattern matching.
Added missing cargo:rerun-if-changed for header.
This reverts commit 0df54a2.
…into add-vcpkg
…into add-vcpkg
So that rust can continue to build.
By this, we can check whether the toolchain matches the vcpkg triplet.
Merge tested CI changes
Emscripten can be missing if it's building for wasm32-unknown-unknown.
|
Since this is only used for getting a sysroot for running clang to generate the enum bindings, perhaps we can solve this in an even simpler way... Could we just copy a couple of files into an Actually, I think I can submit a PR to upstream to remove in the include of |
Oh, I'm sorry. Let me take a glance at |
Yep, I think those ways should be better. |
|
I'm going to close this and will do the (Also, I got a change merged upstream already to remove the inclusion of |
Sounds great :) |
Homebrew only provides emscripten but not a full emsdk, so brew users may need an extra environment variable
EMSCRIPTEN_ROOT.In the past versions, emscripten is considered only when the target is wasm32-unknown-emscripten, but it may be needed for other wasm targets. I add supports for other wasm32 targets. And missing emscripten won't cause a panic for non *-emscripten targets.
And we can test it on wasm32 targets if vcpkg-rs supports them later. Related PR has been merged but has not been published to crates.io.