Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namespaces to Resources #17

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add Namespaces to Resources #17

merged 2 commits into from
Sep 12, 2023

Conversation

daviddyball
Copy link
Contributor

Problem

We currently use Kustomize to render multiple instances of Kafka UI in a single overlay, but doing so results in multiple copies of the same entities being rendered because they aren't correctly namespaced:

Example kustomization.yaml:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

helmCharts:
- releaseName: kafka-ui-1
  namespace: deployment-1
  name: kafka-ui
  repo: https://provectus.github.io/kafka-ui-charts
  version: 0.7.4
- releaseName: kafka-ui-2
  name: kafka-ui
  namespace: deployment-2
  repo: https://provectus.github.io/kafka-ui-charts
  version: 0.7.4

The above should result in 2 copies of each resource, one set for deployment-1 namespace and one for deployment-2 namespace. With the current chart you end up with only one of each resource type except for the Deployment which is correctly namespaced in the template.

@daviddyball daviddyball requested a review from a team as a code owner September 6, 2023 13:09
Copy link
Collaborator

@Narekmat Narekmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daviddyball Hello
Thank you for your cooperation.

@Narekmat Narekmat merged commit 6996eab into provectus:main Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants