Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear messages should not be present when in readonly mode #481

Closed
giom-l opened this issue May 21, 2021 · 1 comment · Fixed by #494
Closed

Clear messages should not be present when in readonly mode #481

giom-l opened this issue May 21, 2021 · 1 comment · Fixed by #494
Assignees
@MBovtriukProvectus
Labels
scope/frontend type/bug Something isn't working
Projects
Release 0.1
Milestone
0.1

Comments

@giom-l
Copy link

giom-l commented May 21, 2021

Describe the bug
I'm currently using the master branch image (Version:v0.0.11-SNAPSHOT(1377e02)) and I configured the readonly mode.
However, when I browse a topic, on "Overview" tab, I can see I can clear messages from a partition.

I'm not sure that should be allowed

Set up
docker run -p 8080:8080 -e KAFKA_CLUSTERS_0_NAME=whatever -e KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS=servers:9092 -e KAFKA_CLUSTERS_0_READONLY=true -d provectuslabs/kafka-ui:master

Expected behavior
When in readonly mode, I shouldn't be able to modify anything.

Screenshots
image
@giom-l giom-l added the type/bug Something isn't working label May 21, 2021
@germanosin germanosin added this to the 0.1 milestone May 21, 2021
@germanosin germanosin added this to To do in Release 0.1 via automation May 21, 2021
@MBovtriukProvectus MBovtriukProvectus self-assigned this May 21, 2021
@giom-l
Copy link
Author

giom-l commented May 21, 2021 •
edited
Loading

I just notice that it also appears on "All topics" screen, as well as "Delete Topic".
Let me know if leaving that in this issue is ok or if I may create another one.
image

TEDMykhailo pushed a commit that referenced this issue May 24, 2021
@MBovtriukProvectus
Clear messages should not be present when in readonly mode #481
cad36cf
TEDMykhailo pushed a commit that referenced this issue May 24, 2021
@MBovtriukProvectus
Clear messages should not be present when in readonly mode #481
23344c2
@workshur workshur linked a pull request May 24, 2021 that will close this issue
Clear messages should not be present when in readonly mode #481 #494
Merged
Release 0.1 automation moved this from To do to Done May 24, 2021
workshur pushed a commit that referenced this issue May 24, 2021
@MBovtriukProvectus
Clear messages should not be present when in readonly mode #481 (#494)
acdcf2e 
* Clear messages should not be present when in readonly mode #481

* Clear messages should not be present when in readonly mode #481
javalover123 pushed a commit to javalover123/kafka-ui that referenced this issue Dec 7, 2022
@MBovtriukProvectus
Clear messages should not be present when in readonly mode provectus#481
48e6d99 
 (provectus#494)

* Clear messages should not be present when in readonly mode provectus#481

* Clear messages should not be present when in readonly mode provectus#481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBovtriukProvectus MBovtriukProvectus

Labels
scope/frontend type/bug Something isn't working
Projects
No open projects
Release 0.1
Done
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Clear messages should not be present when in readonly mode #481 provectus/kafka-ui
3 participants
@germanosin @giom-l @MBovtriukProvectus