Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/1219 #1317

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Issues/1219 #1317

merged 4 commits into from
Dec 28, 2021

Conversation

NelyDavtyan
Copy link
Contributor

@NelyDavtyan NelyDavtyan commented Dec 24, 2021 •
edited by workshur
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Fixes #1219
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@Haarolean Haarolean linked an issue Dec 24, 2021 that may be closed by this pull request
Disable 0 and negative values in Topic Creation #1219
Closed
@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@workshur workshur merged commit f2709ea into master Dec 28, 2021
@workshur workshur deleted the issues/1219 branch December 28, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workshur workshur workshur approved these changes

Assignees
No one assigned
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable 0 and negative values in Topic Creation
3 participants
@NelyDavtyan @workshur @Haarolean