Mock server removal #157
Merged
Mock server removal #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Guzel738
commented
Jan 18, 2021
Guzel738
commented
- mock server directory removed
|
HI! It would be great to update README.md too. |
|
aMoRRoMa
reviewed
Jan 19, 2021
| @@ -24,10 +24,6 @@ If you plan to use full fake REST API you have to update `.env`. | |||
| ``` | |||
| REACT_APP_API_URL=http://localhost:3004 | |||
| ``` | |||
| Start JSON Server if you prefer to use default full fake REST API. | |||
There was a problem hiding this comment.
If mock API is deleted, lines from 23 to 26 don't make sense.
There was a problem hiding this comment.
Also please remove link to JSON server
- * [JSON Server](https://github.com/typicode/json-server) - Fake REST API.
workshur
requested changes
Jan 19, 2021
| @@ -24,10 +24,6 @@ If you plan to use full fake REST API you have to update `.env`. | |||
| ``` | |||
| REACT_APP_API_URL=http://localhost:3004 | |||
| ``` | |||
| Start JSON Server if you prefer to use default full fake REST API. | |||
There was a problem hiding this comment.
Also please remove link to JSON server
- * [JSON Server](https://github.com/typicode/json-server) - Fake REST API.
|
Dependencies related to mock server removed, README file updated |
workshur
approved these changes
Jan 19, 2021
soffest
approved these changes
Jan 19, 2021
aMoRRoMa
approved these changes
Jan 19, 2021
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
Mock server removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.