Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer group details view. #18

Merged
merged 9 commits into from
May 21, 2020

Conversation

soffest
Copy link

@soffest soffest commented Mar 26, 2020

No description provided.

@soffest soffest requested a review from workshur April 2, 2020 10:52
Copy link
Member

@workshur workshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</div>
);
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the indentation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked indentation and I don't see any issues here, it also corresponds to indentation in similar existing files in the project.

@soffest soffest changed the base branch from feature/12-consumer-groups-list to master April 7, 2020 10:28
@soffest soffest changed the title WIP: Consumer group details view. Consumer group details view. Apr 7, 2020
yazebochan and others added 2 commits April 10, 2020 17:53
* temp result commit

* consumer group details api done

* fixes

* changed calls from loop into vars, changed foreach to map

* changes

* removed redundant import

* Refactoring, fixed contract

* Fixed useless group query

* fix-consumer-groups-retaining-cluster-on-cluster-switch

Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local>
Co-authored-by: German Osin <german.osin@gmail.com>
Co-authored-by: Azat Gataullin <gataniel@gmail.com>
@germanosin germanosin added this to To do in Kafka UI Apr 28, 2020
@maksimtereshin maksimtereshin self-assigned this May 14, 2020
@maksimtereshin maksimtereshin moved this from To do to In progress in Kafka UI May 14, 2020
@maksimtereshin maksimtereshin merged commit 0815739 into master May 21, 2020
@maksimtereshin maksimtereshin deleted the feature/12-consumer-group-details branch May 21, 2020 11:10
@germanosin germanosin moved this from In progress to Done in Kafka UI Aug 12, 2020
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* Added concumer groups list with search.

* Added consumer group details view.

* Minor tweaks.

* Backend group details (provectus#19)

* temp result commit

* consumer group details api done

* fixes

* changed calls from loop into vars, changed foreach to map

* changes

* removed redundant import

* Refactoring, fixed contract

* Fixed useless group query

* fix-consumer-groups-retaining-cluster-on-cluster-switch

Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local>
Co-authored-by: German Osin <german.osin@gmail.com>
Co-authored-by: Azat Gataullin <gataniel@gmail.com>

* Add loader, fix details

* Add empty text for consumer groups

Co-authored-by: Sofia Shnaidman <sshnaidman@provectus.com>
Co-authored-by: Roman Nedzvetskiy <gmcodemail@gmail.com>
Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local>
Co-authored-by: German Osin <german.osin@gmail.com>
Co-authored-by: Azat Gataullin <gataniel@gmail.com>
Co-authored-by: Maxim Tereshin <tereshin93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Kafka UI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants