Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics UI #2

Merged
merged 42 commits into from
Jan 27, 2020
Merged

Topics UI #2

merged 42 commits into from
Jan 27, 2020

Conversation

workshur
Copy link
Member

No description provided.

src/components/App.tsx Show resolved Hide resolved
src/components/Brokers/Brokers.tsx Show resolved Hide resolved
src/components/Nav/ClusterMenu.tsx Show resolved Hide resolved
}) => {
const [showInternal, setShowInternal] = React.useState<boolean>(true);

const handleSwitch = () => setShowInternal(!showInternal);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make sense to getting value from checkbox?

src/components/Topics/List/ListItem.tsx Show resolved Hide resolved
</div>

<div className="box">
<form onSubmit={handleSubmit(onSubmit)}>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about create enums for select's values?

src/lib/hooks/useInterval.ts Show resolved Hide resolved
@aMoRRoMa
Copy link

In any cases, if need help, just notify;)

@workshur workshur merged commit 7193af2 into master Jan 27, 2020
@workshur workshur deleted the feature/topics_ui_react branch January 27, 2020 15:32
Haarolean added a commit that referenced this pull request Jan 25, 2022
Signed-off-by: Roman Zabaluev <rzabaluev@provectus.com>
Haarolean added a commit that referenced this pull request Jan 25, 2022
* required PR checks workflows adaptation

* Temporarily ignore broken e2e tests. TODO #1480

Signed-off-by: Roman Zabaluev <rzabaluev@provectus.com>

* Ignore e2e tests attempt #2

Signed-off-by: Roman Zabaluev <rzabaluev@provectus.com>

Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Narekmat added a commit that referenced this pull request Nov 18, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* required PR checks workflows adaptation

* Temporarily ignore broken e2e tests. TODO provectus#1480

Signed-off-by: Roman Zabaluev <rzabaluev@provectus.com>

* Ignore e2e tests attempt provectus#2

Signed-off-by: Roman Zabaluev <rzabaluev@provectus.com>

Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Donutellko pushed a commit to Donutellko/kafka-ui that referenced this pull request Jul 12, 2024
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants