Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some sonar issues #2110

Closed
wants to merge 7 commits into from
Closed

Fix some sonar issues #2110

wants to merge 7 commits into from

Conversation

MaratGumarov
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@MaratGumarov MaratGumarov self-assigned this Jun 3, 2022
@MaratGumarov MaratGumarov added this to In progress in Release 0.5 via automation Jun 3, 2022
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jun 3, 2022
@MaratGumarov MaratGumarov linked an issue Jun 3, 2022 that may be closed by this pull request
BE: Fix sonar code smells #1911
Closed
@MaratGumarov MaratGumarov changed the title Fixing some sonar issues Fix some sonar issues Jun 3, 2022
@MaratGumarov MaratGumarov marked this pull request as ready for review June 3, 2022 13:30
@MaratGumarov MaratGumarov requested review from a team as code owners June 3, 2022 13:30
Haarolean
Haarolean suggested changes Jun 4, 2022
View reviewed changes
kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/tests/ConnectorsTests.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/base/BaseTest.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/SmokeTests.java Outdated Show resolved Hide resolved
...ui-api/src/test/java/com/provectus/kafka/ui/util/jsonschema/AvroJsonSchemaConverterTest.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/util/jsonschema/AvroJsonSchemaConverter.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/strategy/ksql/statement/BaseStrategy.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ksql/response/ResponseParser.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/MessagesService.java Outdated Show resolved Hide resolved
Release 0.5 automation moved this from In progress to Review in progress Jun 4, 2022
@Haarolean Haarolean added scope/backend type/chore Boring stuff, could be refactoring or tech debt and removed status/triage Issues pending maintainers triage labels Jun 4, 2022
@Haarolean Haarolean removed this from Review in progress in Release 0.5 Jun 4, 2022
@Haarolean Haarolean requested a review from a team June 4, 2022 13:36
@Haarolean Haarolean requested review from iliax and a team June 10, 2022 15:14
@MaratGumarov MaratGumarov force-pushed the issues/1911-fix_sonar_code_smell branch from ab41bec to 73e054d Compare June 14, 2022 08:27
@Haarolean
Copy link
Contributor

do not merge before #2125

@Haarolean Haarolean added status/on-hold Waiting for something, but not the user input. status/blocked Further development process is blocked by something. Prevents merging for PRs. labels Jul 7, 2022
iliax
iliax reviewed Jul 7, 2022
View reviewed changes
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ksql/response/ResponseParser.java
Comment on lines +152 to +153
final var properties = "properties";
final var overwrittenProperties = "overwrittenProperties";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is "better" than original one. Looks very strange..

@Haarolean Haarolean assigned iliax and unassigned MaratGumarov and iliax Oct 17, 2022
@Haarolean Haarolean deleted the issues/1911-fix_sonar_code_smell branch December 20, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliax iliax iliax left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
scope/backend status/blocked Further development process is blocked by something. Prevents merging for PRs. status/on-hold Waiting for something, but not the user input. type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE: Fix sonar code smells
3 participants
@MaratGumarov @Haarolean @iliax