Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/24-add-eslint #26

Merged
merged 6 commits into from
Apr 14, 2020
Merged

enhancement/24-add-eslint #26

merged 6 commits into from
Apr 14, 2020

Conversation

Gataniel
Copy link
Contributor

@Gataniel Gataniel commented Apr 10, 2020 •
edited
Loading

#24

@Gataniel Gataniel added type/enhancement En enhancement to an already existing feature scope/frontend labels Apr 10, 2020
@Gataniel Gataniel added this to To do in Kafka UI Apr 10, 2020
@Gataniel Gataniel linked an issue Apr 10, 2020 that may be closed by this pull request
Add ESlint #24
Closed
@Gataniel Gataniel moved this from To do to In progress in Kafka UI Apr 10, 2020
@Gataniel Gataniel force-pushed the enhancement/24-add-eslint branch 2 times, most recently from 8bc479a to d18ec19 Compare April 13, 2020 10:25
@Gataniel Gataniel self-assigned this Apr 13, 2020
@Gataniel Gataniel changed the title enhancement/24-init-standard-eslint enhancement/24-add-eslint Apr 13, 2020
@workshur
Copy link
Member

@aMoRRoMa Could you please verify and suggest rules we need to add?
From my prospective the config must be as strict as possible

aMoRRoMa
aMoRRoMa approved these changes Apr 14, 2020
View reviewed changes
kafka-ui-react-app/package.json Outdated Show resolved Hide resolved
kafka-ui-react-app/package.json Outdated
"eslint -c .eslintrc.json --fix",
"git add"
],
"*.js": "eslint --cache --fix"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really need?

@aMoRRoMa
Copy link

aMoRRoMa commented Apr 14, 2020 •
edited
Loading

@aMoRRoMa Could you please verify and suggest rules we need to add?
From my prospective the config must be as strict as possible

@workshur I agree about strict and we could start from all recommended rules and maybe update rules list in the future a little bit.

aMoRRoMa
aMoRRoMa reviewed Apr 14, 2020
View reviewed changes
kafka-ui-react-app/.eslintrc.json
}
],
"prettier/prettier": "error",
"@typescript-eslint/explicit-function-return-type": "off",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@workshur @Gataniel What do you think about switch on that rule?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gataniel We can do that in context of separate ticket. "Turn @typescript-eslint/explicit-function-return-type rule ON and fix all broken functions then"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

@Gataniel Gataniel merged commit e2918b4 into master Apr 14, 2020
@Gataniel Gataniel moved this from In progress to Done in Kafka UI Apr 14, 2020
@Gataniel Gataniel deleted the enhancement/24-add-eslint branch April 14, 2020 12:36
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@Gataniel
Merge pull request provectus#26 from provectus/enhancement/24-add-eslint
b83d7ad 
enhancement/24-add-eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aMoRRoMa aMoRRoMa aMoRRoMa approved these changes

@workshur workshur workshur approved these changes

Assignees

@Gataniel Gataniel

Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
No open projects
Kafka UI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ESlint
3 participants
@Gataniel @workshur @aMoRRoMa