#253: Get messages implementation improvement #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2021 15:11
2. Tests for OffsetsSeek, RecordEmitter added
…_RecordEmitter_improvement
added 4 commits
March 23, 2021 11:23
…_RecordEmitter_improvement � Conflicts: � kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ClusterService.java � kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ConsumingService.java � kafka-ui-api/src/test/java/com/provectus/kafka/ui/AbstractBaseTest.java � kafka-ui-api/src/test/java/com/provectus/kafka/ui/producer/KafkaTestProducer.java
|
SonarCloud Quality Gate failed. |
germanosin
approved these changes
Mar 23, 2021
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* 1. End offsets check added to RecordEmitter 2. Tests for OffsetsSeek, RecordEmitter added * Tests improvements * ISSUE-257: checkstyle * ISSUE-257: withSchemaType sonar fix * ISSUE-257: withSchemaType sonar fix Co-authored-by: Ilya Kuramshin <ikuramshin@provectus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To discuss: currently I placed RecordEmitter-related classes in ConsumingService, which is not looking pretty, imho.
I think it is better to extract RecordEmitter as top level class to "polling" package and place all related classes into it