Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#257: ErrorResponse format description #294

Merged
merged 9 commits into from
Mar 23, 2021
Merged

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Mar 22, 2021

No description provided.

@iliax iliax changed the title ISSUE-257: ErrorResponse format description added WIP: ISSUE-257: ErrorResponse format description added Mar 22, 2021
@iliax iliax changed the title WIP: ISSUE-257: ErrorResponse format description added WIP: ISSUE-257: ErrorResponse format description Mar 22, 2021
@iliax iliax linked an issue Mar 22, 2021 that may be closed by this pull request
@iliax
Copy link
Contributor Author

iliax commented Mar 22, 2021

@workshur please review the format and I will add it as 4XX & 5XX responses to all endpoints after

1. ErrorCode class added
2. GlobalErrorWebExceptionHandler refactored to handle all types of exceptions
3. All CustomBaseExceptions now expose ErrorCode instead of HttpStatus
@iliax iliax changed the title WIP: ISSUE-257: ErrorResponse format description ISSUE-257: ErrorResponse format description Mar 22, 2021
Ilya Kuramshin added 4 commits March 23, 2021 10:57
…_Error_response_format

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/ReadOnlyModeFilter.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/CustomBaseException.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/DuplicateEntityException.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/GlobalErrorAttributes.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/GlobalErrorWebExceptionHandler.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/NotFoundException.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/ReadOnlyException.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/RebalanceInProgressException.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/UnprocessableEntityException.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/ValidationException.java
@iliax iliax closed this Mar 23, 2021
@iliax iliax reopened this Mar 23, 2021
@germanosin germanosin changed the title ISSUE-257: ErrorResponse format description #257: ErrorResponse format description Mar 23, 2021
@iliax iliax merged commit 106c42e into master Mar 23, 2021
@iliax iliax deleted the ISSUE-257_Error_response_format branch March 23, 2021 13:44
@germanosin germanosin added this to the 0.1 milestone Mar 23, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* ISSUE-257: ErrorResponse format description & processing added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Kafka UI
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Add error response format contract
4 participants