-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema registry views #317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks good so far |
workshur
reviewed
Mar 29, 2021
workshur
reviewed
Apr 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
kafka-ui-react-app/src/components/Schemas/Edit/__tests__/Edit.spec.tsx
Outdated
Show resolved
Hide resolved
kafka-ui-react-app/src/components/Schemas/Edit/__tests__/Edit.spec.tsx
Outdated
Show resolved
Hide resolved
workshur
reviewed
Apr 12, 2021
kafka-ui-react-app/src/components/Schemas/Edit/__tests__/Edit.spec.tsx
Outdated
Show resolved
Hide resolved
marat-ad
reviewed
Apr 21, 2021
Closed
Kudos, SonarCloud Quality Gate passed! |
workshur
approved these changes
Apr 22, 2021
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* Add schema type select to the form * Implement adding new version of a schema * Fix some issues & Increase test coverage * Add more tests * Add compatibility level update * Abstract updating schema into a separate thunk & test it * Remove warnings and skipped test * Update failed tests * Update failing tests * Update markup * Make the JSONEditor a part of the form * Fix linting problem * Fix errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added select with the schema type in the New Schema form
![image](https://user-images.githubusercontent.com/31561808/115557661-99a0c880-a2ba-11eb-97da-6e5106e943c3.png)
Implemented the page for editing the schema and saving it as a new version