Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema registry views #317

Merged
merged 18 commits into from
Apr 22, 2021
Merged

Schema registry views #317

merged 18 commits into from
Apr 22, 2021

Conversation

GneyHabub
Copy link
Contributor

@GneyHabub GneyHabub commented Mar 25, 2021

Added select with the schema type in the New Schema form
Implemented the page for editing the schema and saving it as a new version
image

@GneyHabub GneyHabub requested a review from workshur March 25, 2021 15:52
@workshur
Copy link
Member

looks good so far

@GneyHabub GneyHabub marked this pull request as ready for review April 5, 2021 06:27
@GneyHabub GneyHabub requested a review from workshur April 5, 2021 06:27
@GneyHabub GneyHabub changed the title WIP: Schema registry views Schema registry views Apr 5, 2021
Copy link
Member

@workshur workshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@GneyHabub GneyHabub requested a review from workshur April 12, 2021 08:49
@marat-ad marat-ad self-requested a review April 21, 2021 11:12
@workshur workshur linked an issue Apr 22, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.1% 83.1% Coverage
0.0% 0.0% Duplication

@workshur workshur merged commit caec4eb into master Apr 22, 2021
@workshur workshur deleted the feature/schema-registry-views branch April 22, 2021 13:26
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* Add schema type select to the form

* Implement adding new version of a schema

* Fix some issues & Increase test coverage

* Add more tests

* Add compatibility level update

* Abstract updating schema into a separate thunk & test it

* Remove warnings and skipped test

* Update failed tests

* Update failing tests

* Update markup

* Make the JSONEditor a part of the form

* Fix linting problem

* Fix errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema Registry views.
3 participants