Enhancement/improve time to retain usability v2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazebochan
added a commit
that referenced
this pull request
May 12, 2020
* Refactor for mono (#28) * starting refactor mono * topics and cluster refactored into mono way instead of get * fixed dirty mistakes * param * changed collecttopicdata method to correctly * refactored metrics to copyonwrite methoology * metrics params updated * fixed silly mistake * Let's think immutable * immutable * dumb mistakes fixed * changed to immutable * added new mappers * changed to immutable * typo was fixed * imports were cleared * Refactored * imports were optimized Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local> Co-authored-by: German Osin <german.osin@gmail.com> * need to refactor * issue-31/add-ui-prefix-for-react-routes (#34) * issue-31/add-ui-prefix-for-react-routes * added route for /ui path (#40) Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local> Co-authored-by: Roman Nedzvetskiy <gmcodemail@gmail.com> Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local> * fix-bug-topic-not-creatable-when-no-custom-params (#37) * fix-bug-topic-not-creatable-when-no-custom-params * remove-linter-changes-to-cleanup-PR * Enhancement/improve time to retain usability v2 (#35) * enhancement/improve-time-to-retain-usability * add-btn-controls-for-time-to-retain-for-topics * updating of topic done properly * Added supportedCommands enum in cluster for getting correct method for topics settings update, changed request version from patch to put * AdminClient now boxed into extendedAdminClient * Redundant imports removed * SupportedFeatures method moved to util * Methods of updating cluster separated * Subsribed to change topics methods, replaced path of ts class * fix-routes-for-details (#45) * Added test and changed getAdminClient logic from clusterId to clusterName * Changed updating methods mono logic, added update cluster topic method * Fixed test by removing updateCluster calls, fixed add topic * Removed redundant injection and import * Added behaviour if topic wasn't created * Removed redundant imports * Dublicate lines in ClusterService moved to updateCluster method * CreateTopic method updated -- now returns topicName, update topic method changed -- removed redundant param clusterName Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local> Co-authored-by: German Osin <german.osin@gmail.com> Co-authored-by: Azat Gataullin <Gataniel@gmail.com>
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* enhancement/improve-time-to-retain-usability * add-btn-controls-for-time-to-retain-for-topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21
time to retain field is hard to use due to its value in ms
made the field more user-friendly by adding buttons to the bottom of the input which set the value in ms, but represent it as custom text within a button, f.e 12h, 1d, 2d, 1w etc
the first option was to use html5 datalist, but I changed my mind since its well supported in Chrome only, as for the other browsers its not that usable, especially Safari