Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/messages-timestamp-filter update seekTo prop condition #3569

Merged
merged 2 commits into from
Mar 28, 2023
Merged

bugfix/messages-timestamp-filter update seekTo prop condition #3569

merged 2 commits into from
Mar 28, 2023

Conversation

NeiruBugz
Copy link
Contributor

@NeiruBugz NeiruBugz commented Mar 28, 2023 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Update condition for adding seekTo query to payload
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@NeiruBugz NeiruBugz requested a review from a team as a code owner March 28, 2023 11:02
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Mar 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Mar 28, 2023
@github-actions
Copy link

Custom deployment will be available at http://pr3569.internal.kafka-ui.provectus.io

@Haarolean Haarolean self-requested a review March 28, 2023 12:35
@Haarolean Haarolean added type/bug Something isn't working scope/frontend and removed status/triage Issues pending maintainers triage labels Mar 28, 2023
@Haarolean Haarolean linked an issue Mar 28, 2023 that may be closed by this pull request
0.6.0: Timestamp filter is broken #3573
Closed
@Haarolean Haarolean added the type/regression Something that has been previously fixed but got broken again label Mar 28, 2023
@Haarolean Haarolean linked an issue Mar 28, 2023 that may be closed by this pull request
Topics: Messages filtering by seek type is broken within Topic profile #3317
Open
@Haarolean Haarolean merged commit ef0dacb into master Mar 28, 2023
@Haarolean Haarolean deleted the bugfix/messages-timestamp-filter branch March 28, 2023 12:45
@github-actions
Copy link

Custom deployment removed

@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Custom deployment removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
scope/frontend type/bug Something isn't working type/regression Something that has been previously fixed but got broken again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topics: Messages filtering by seek type is broken within Topic profile 0.6.0: Timestamp filter is broken
2 participants
@NeiruBugz @Haarolean