#356 added endpoint to fetch all cluster connectors #361
Conversation
RamazanYapparov
requested review from
workshur,
iliax,
germanosin and
IldarAlmakaev
| status: | ||
| type: string | ||
| enum: | ||
| - RUNNING |
There was a problem hiding this comment.
You already have this status enum, please just share it
There was a problem hiding this comment.
Fixed, thanks
| type: | ||
| type: string | ||
| enum: | ||
| - source |
There was a problem hiding this comment.
Please use camel case for enums
There was a problem hiding this comment.
Fixed, thanks
| @@ -43,6 +53,58 @@ | |||
| ); | |||
| } | |||
|
|
|||
| public Flux<FullConnectorInfo> getAllConnectors(String clusterName) { | |||
| return getConnects(clusterName) | |||
There was a problem hiding this comment.
Method looks overcomplicated, could we split it?
There was a problem hiding this comment.
Fixed, thanks
| FullConnectorInfo.StatusEnum.valueOf(triple.getLeft().getStatus().getState().name()) | ||
| ) | ||
| .tasksCount(triple.getRight().size()) | ||
| .hasFailedTasks(triple.getRight().stream() |
There was a problem hiding this comment.
Could we pass number of failed tasks instead? I think it will be more useful
There was a problem hiding this comment.
Fixed, thanks
| .collectList() | ||
| .map(tasks -> Triple.of(pair.getLeft(), pair.getRight(), tasks)) | ||
| ) | ||
| .map(triple -> new FullConnectorInfo() |
There was a problem hiding this comment.
Could you please move it into mapper?
There was a problem hiding this comment.
Fixed, thanks
- refactoring schema - added connector class property
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
workshur
deleted the
feature/add_endpoint_to_fetch_all_cluster_connectors
branch
…us#361) * added endpoint to fetch all cluster connectors * - refactoring code - refactoring schema - added connector class property
Fixes #356