Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issues-211] - Clearing up messages from a topic #378

Merged
merged 11 commits into from
Apr 22, 2021
Merged

[issues-211] - Clearing up messages from a topic #378

merged 11 commits into from
Apr 22, 2021

Conversation

TEDMykhailo
Copy link
Contributor

added button: clear messages for this topic
Screenshot 2021-04-15 at 13 14 11

added button: clear all messages for this topic and added button: clear messages for permission
Screenshot 2021-04-15 at 13 14 47

Copy link
Member

@workshur workshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid so far

kafka-ui-react-app/src/redux/actions/thunks/topics.ts Outdated Show resolved Hide resolved
kafka-ui-react-app/src/redux/actions/thunks/topics.ts Outdated Show resolved Hide resolved
# Conflicts:
#	kafka-ui-react-app/src/components/Topics/List/ListItem.tsx
#	kafka-ui-react-app/src/components/Topics/List/__tests__/ListItem.spec.tsx
#	kafka-ui-react-app/src/components/Topics/Topic/Details/Details.tsx
#	kafka-ui-react-app/src/components/Topics/Topic/Details/DetailsContainer.ts
@TEDMykhailo TEDMykhailo changed the title WIP: [issues-211] - Clearing up messages from a topic [issues-211] - Clearing up messages from a topic Apr 21, 2021
@workshur workshur requested a review from marat-ad April 21, 2021 14:38
@workshur
Copy link
Member

Looks good so far. Please add test for reducer

Copy link
Member

@marat-ad marat-ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@workshur workshur linked an issue Apr 22, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@workshur workshur merged commit c86c955 into master Apr 22, 2021
@workshur workshur deleted the test211 branch April 22, 2021 11:28
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
Co-authored-by: mbovtryuk <mbovtryuk@provectus.com>
Donutellko pushed a commit to Donutellko/kafka-ui that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing up messages from a topic
4 participants