Fix the problem with instant redirect #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GneyHabub
commented
Apr 24, 2021
GneyHabub
commented
- Fixed the problem with redirecting after an error
- Fixed the problem with the height of JSONEditor
- Slightly improved the schema edition form
marat-ad
reviewed
Apr 26, 2021
There was a problem hiding this comment.
I think we should call each api request in updateSchema thunk instead of dispatching other thunks, since update is a separate user action, which should have its own request/success/failure action callers. In that case we can use try/catch inside updateSchema, throw an error in the end of catch block, and catch this error in the component to determine if we should redirect or not. That will allow us avoid using all those statuses updates and get rid of confusing useEffects.
kafka-ui-react-app/src/components/common/JSONEditor/JSONEditor.tsx
Outdated
Show resolved
Hide resolved
marat-ad
reviewed
Apr 27, 2021
|
SonarCloud Quality Gate failed. |
marat-ad
approved these changes
Apr 28, 2021
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* Fix the problem with instant redirect * Rewrite updateSchema thunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.