[issues-357] - User should not be able to update/delete #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs. Add confirmation for all delete/reset actions
marat-ad
reviewed
Apr 26, 2021
kafka-ui-react-app/src/components/Topics/List/__tests__/ListItem.spec.tsx
Outdated
Show resolved
Hide resolved
kafka-ui-react-app/src/components/Topics/Topic/Details/Details.tsx
Outdated
Show resolved
Hide resolved
…cs. Add confirmation for all delete/reset actions
…cs. Add confirmation for all delete/reset actions
marat-ad
approved these changes
Apr 27, 2021
kafka-ui-react-app/src/components/Topics/Topic/Details/Details.tsx
Outdated
Show resolved
Hide resolved
…cs. Add confirmation for all delete/reset actions
…cs. Add confirmation for all delete/reset actions
workshur
requested changes
May 3, 2021
| onClick={() => | ||
| clearTopicMessages(clusterName, topicName, [partition]) | ||
| {!internal ? ( | ||
| <td className="has-text-right"> |
There was a problem hiding this comment.
I would suggest to hide children of this td instead. In other case to make html of the table valid you need to hide th too
| <DropdownItem | ||
| onClick={() => setDeleteTopicConfirmationVisible(true)} | ||
| {!internal ? ( | ||
| <td className="value"> |
There was a problem hiding this comment.
This behaviour makes html of the table invalid. Please apply !internal to child element of last td in a row
|
Kudos, SonarCloud Quality Gate passed! |
workshur
approved these changes
May 11, 2021
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* [issues-357] - User should not be able to update/delete internal topics. Add confirmation for all delete/reset actions * [issues-357] - User should not be able to update/delete internal topics. Add confirmation for all delete/reset actions * [issues-357] - User should not be able to update/delete internal topics. Add confirmation for all delete/reset actions * [issues-357] - User should not be able to update/delete internal topics. Add confirmation for all delete/reset actions * [issues-357] - User should not be able to update/delete internal topics. Add confirmation for all delete/reset actions * [issues-357] - User should not be able to update/delete Co-authored-by: mbovtryuk <mbovtryuk@provectus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User should not be able to update/delete internal topics. Add confirmation for all delete/reset actions
if topic is internal you don't see an action button