Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Logout button link is bound to a wrong div #4045

Merged
merged 2 commits into from
Aug 1, 2023
Merged

FE: Logout button link is bound to a wrong div #4045

merged 2 commits into from
Aug 1, 2023

Conversation

Haarolean
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #4016

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added scope/frontend type/chore Boring stuff, could be refactoring or tech debt labels Jul 18, 2023
@Haarolean Haarolean self-assigned this Jul 18, 2023
@Haarolean Haarolean requested a review from a team as a code owner July 18, 2023 07:04
@Haarolean Haarolean added type/bug Something isn't working and removed type/chore Boring stuff, could be refactoring or tech debt labels Jul 18, 2023
@Haarolean Haarolean mentioned this pull request Jul 18, 2023
Closed
13 tasks
@Haarolean Haarolean enabled auto-merge (squash) July 24, 2023 07:26
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Haarolean Haarolean disabled auto-merge August 1, 2023 14:27
@Haarolean Haarolean merged commit 3cde6c2 into master Aug 1, 2023
10 checks passed
@Haarolean Haarolean deleted the issues/4016.2 branch August 1, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mgrdich Mgrdich Mgrdich approved these changes

Assignees

@Haarolean Haarolean

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Logout button link is bound to a wrong div
2 participants
@Haarolean @Mgrdich