Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#449 adding issue templates, pr template #472

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

mikementor
Copy link
Contributor

@mikementor mikementor commented May 18, 2021

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Added pull-request template and issue templates - bug report + feature request
Also added task checker and pr-description-enforcer -
build should fail, if some of the checkboxes from checklist aren't checked or PR description is default one
Is there anything you'd like reviewers to focus on?
Isn't it a lot of checkboxes? Should we be doing something more lightweight?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct
---- Screenshots---

image
image
image
image

@mikementor mikementor merged commit 407375c into master May 18, 2021
@mikementor mikementor deleted the github/449-pr-templates branch May 18, 2021 10:25
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* adding issue templates, pr template

* fixed pr template

Co-authored-by: marat <ttx013@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants