The key of the message is not visible / accessible #377 #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workshur
approved these changes
May 19, 2021
kafka-ui-react-app/src/components/Topics/Topic/Details/Messages/MessagesTable.tsx
Outdated
Show resolved
Hide resolved
| @@ -19,6 +19,7 @@ const MessagesTable: React.FC<MessagesTableProp> = ({ messages, onNext }) => { | |||
| <table className="table is-fullwidth"> | |||
| <thead> | |||
| <tr> | |||
| <th>Key</th> | |||
There was a problem hiding this comment.
since the key column is sometimes empty, I suggest moving it to the second position. After timestamp. cc: @germanosin
kafka-ui-react-app/src/components/Topics/Topic/Details/Messages/MessageItem.tsx
Outdated
Show resolved
Hide resolved
kafka-ui-react-app/src/components/Topics/Topic/Details/Messages/MessageItem.tsx
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
workshur
approved these changes
May 20, 2021
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
…vectus#477) * The key of the message is not visible / accessible provectus#377 * The key of the message is not visible / accessible provectus#377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add column key, and render value