Added segmentSize for topic level #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanosin
suggested changes
May 14, 2020
| @@ -44,7 +42,8 @@ | |||
| ac -> getClusterMetrics(ac).flatMap( clusterMetrics -> | |||
| getTopicsData(ac).flatMap( topics -> | |||
| loadTopicsConfig(ac, topics.stream().map(InternalTopic::getName).collect(Collectors.toList())) | |||
| .map( configs -> mergeWithConfigs(topics, configs) ) | |||
| .map( configs -> mergeWithConfigs(topics, configs)) | |||
There was a problem hiding this comment.
Could we collect replication data before and merge it with topics/configs?
| private Mono<Map<String, InternalTopic>> updateSegmentSize(AdminClient ac, InternalClusterMetrics clusterMetrics, Map<String, InternalTopic> internalTopic) { | ||
| return ClusterUtil.toMono(ac.describeLogDirs(clusterMetrics.getBrokersIds()).all()) | ||
| .map(l -> { | ||
| System.out.println(l); |
| @@ -20,6 +20,6 @@ | |||
| private final int replicationFactor; | |||
| private final int underReplicatedPartitions; | |||
| //TODO: find way to fill | |||
| private final int segmentSize; | |||
| private final long segmentSize; | |||
| private final int segmentCount; | |||
There was a problem hiding this comment.
remove count int this case
| @@ -22,4 +24,5 @@ | |||
| //TODO: find way to fill | |||
| private final int segmentSize; | |||
| private final int segmentCount; | |||
| private final List<Integer> brokersIds; | |||
There was a problem hiding this comment.
why brokerIds appeared in metrics?
added 7 commits
May 18, 2020 10:38
… added partition collecting in topic
germanosin
approved these changes
May 28, 2020
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* Added segmentSize for topic level * Added segmentSize to clusterMetrics object * Added internalClusterState for storing clusterMetrics linked to cluster's brokersIds * InternalBrokersMetrics param added to InternalClusterMetrics * Changed topic segment counting logic by finding the partition leader, added partition collecting in topic * Added segmentSize info to cluster, broker, topic and topicPartition level * Reduce to map moved to clusterutil, leader moved in cache * Cleared some code Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.