Topic messages API. Reactive consumer #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/10-reactive-consumer-concept
germanosin
suggested changes
May 26, 2020
kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/ClusterService.java
Show resolved
Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/ClusterService.java
Show resolved
Hide resolved
| private final KafkaCluster cluster; | ||
| private final String topic; | ||
|
|
||
| public void emit(FluxSink<ConsumerRecord<String, String>> sink) { |
There was a problem hiding this comment.
I'll use Bytes,Bytes here
There was a problem hiding this comment.
This is an early version of the backend for messages API and it supports only the simplest case. Will change that along with adding support of different message types.
| Properties props = new Properties(); | ||
| props.put(ConsumerConfig.CLIENT_ID_CONFIG, "kafka-ui"); | ||
| props.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, cluster.getBootstrapServers()); | ||
| props.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class); |
There was a problem hiding this comment.
Done, but with BytesDeserializer. BytesSerde doesn't implement required interfaces.
germanosin
suggested changes
May 26, 2020
| } | ||
|
|
||
| private void assignPartitions(KafkaConsumer<String, String> consumer, String topic) { | ||
| List<TopicPartition> partitions = consumer.partitionsFor(topic).stream() |
There was a problem hiding this comment.
get number of partitions from internal state
germanosin
approved these changes
May 27, 2020
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* Topic messages API. Reactive consumer * Topic messages API. Reactive consumer * Review changes
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.