Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks/424 creating topic UI check #508

Merged
merged 16 commits into from
Jun 9, 2021

Conversation

bvolodarskiy
Copy link
Contributor

@bvolodarskiy bvolodarskiy commented May 31, 2021

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

Copy link
Contributor

@mikementor mikementor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 53 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikementor mikementor merged commit 760149e into master Jun 9, 2021
@mikementor mikementor deleted the checks/424-creating-topic-ui-check branch June 9, 2021 09:09
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* kafka-create-topic-test

* waituntil

* steps

* topic tests

* fixed ui topic test(refresh page until element is present

* fixed refreshUntil method

* kafka-create-topic-test

* waituntil

* steps

* topic tests

* fixed ui topic test(refresh page until element is present

* fixed refreshUntil method

* changed test name for topic creation

* try comment afterAll to fix

* moved steps folder form main to test

Co-authored-by: marat <ttx013@gmail.com>
Co-authored-by: Bogdan Volodarskiy <bvolodarskiy@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants