Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect to a newly created topic #514

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

GneyHabub
Copy link
Contributor

After updating react-hook-form to the latest version a bug appeared in the component for creating a new topic - the values of the form were undefined, after the form fields became disabled. That resulted in redirecting to topics/undefined after the topic was successfully created. Official documentation suggests that we should disable the whole fieldset in such cases.

How Has This Been Tested?

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

@GneyHabub GneyHabub requested a review from workshur June 2, 2021 11:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@GneyHabub GneyHabub merged commit 0c9ff4c into master Jun 3, 2021
@GneyHabub GneyHabub deleted the hotfix/redirect-after-form-submit branch June 3, 2021 08:06
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants