Added begin and end offset param #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanosin
suggested changes
Jul 15, 2020
| @@ -290,6 +290,28 @@ paths: | |||
| items: | |||
| $ref: '#/components/schemas/ConsumerGroup' | |||
|
|
|||
| /api/clusters/offsets/{clusterName}: | |||
There was a problem hiding this comment.
Why do we need special endpoint? Could we add this to exist topic partition list?
| @@ -351,4 +351,40 @@ private InternalClusterMetrics collectTopicsMetrics(Map<String,InternalTopic> to | |||
| }) | |||
| ); | |||
| } | |||
|
|
|||
| public Mono<Map<String, BigDecimal>> getOffsets (AdminClient ac, KafkaCluster c) { | |||
There was a problem hiding this comment.
What is String? TopicPartition?
There was a problem hiding this comment.
Topic-Partition-max/min to avoid creating new object in swagger
| }); | ||
| } | ||
|
|
||
| private Mono<List<Map<String, List<Integer>>>> getTopicPartitionList(AdminClient ac) { |
There was a problem hiding this comment.
I don't think we need all these offsets in one time
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* Added begin and end offset param * moved consumer to try with resources block * Fixed some problems * Moved to gettopicdetails * Cleanup code Co-authored-by: Roman Nedzvetskiy <roman@Romans-MacBook-Pro.local> Co-authored-by: German Osin <german.osin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.