Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server startup banner #912

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Server startup banner #912

merged 2 commits into from
Sep 29, 2021

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Sep 27, 2021

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Ascii banner added to replace default spring banner.
I am ok to use any other font, just wanted to replace default one)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 113 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@germanosin germanosin merged commit 6920a25 into master Sep 29, 2021
@germanosin germanosin deleted the server_banner branch September 29, 2021 09:24
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* server startup banner added

* font changed

Co-authored-by: Ilya Kuramshin <ikuramshin@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants