Skip to content

Commit

Permalink
refactor: add error log when iavl set failed (cosmos#13803)
Browse files Browse the repository at this point in the history
* add error log when iavl set failed

Ref: cosmos#12012

* Update CHANGELOG.md

* play safe
  • Loading branch information
yihuang committed Nov 9, 2022
1 parent a785bf5 commit 22f3261
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* [#13236](https://github.com/cosmos/cosmos-sdk/pull/13236) Integrate Filter Logging
* [#13528](https://github.com/cosmos/cosmos-sdk/pull/13528) Update `ValidateMemoDecorator` to only check memo against `MaxMemoCharacters` param when a memo is present.
* [#13651](https://github.com/cosmos/cosmos-sdk/pull/13651) Update `server/config/config.GetConfig` function.
* [#13803](https://github.com/cosmos/cosmos-sdk/pull/13803) Add an error log if iavl set operation failed.

### State Machine Breaking

Expand Down
11 changes: 8 additions & 3 deletions store/iavl/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ var (

// Store Implements types.KVStore and CommitKVStore.
type Store struct {
tree Tree
tree Tree
logger log.Logger
}

// LoadStore returns an IAVL Store as a CommitKVStore. Internally, it will load the
Expand Down Expand Up @@ -87,7 +88,8 @@ func LoadStoreWithInitialVersion(db dbm.DB, logger log.Logger, key types.StoreKe
}

return &Store{
tree: tree,
tree: tree,
logger: logger,
}, nil
}

Expand Down Expand Up @@ -198,7 +200,10 @@ func (st *Store) CacheWrapWithListeners(storeKey types.StoreKey, listeners []typ
func (st *Store) Set(key, value []byte) {
types.AssertValidKey(key)
types.AssertValidValue(value)
st.tree.Set(key, value)
_, err := st.tree.Set(key, value)
if err != nil && st.logger != nil {
st.logger.Error("iavl set error", "error", err.Error())
}
}

// Implements types.KVStore.
Expand Down

0 comments on commit 22f3261

Please sign in to comment.