Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine proper IBC settings for genesis/migration #102

Closed
4 tasks
iramiller opened this issue Feb 24, 2021 · 0 comments · Fixed by #207
Closed
4 tasks

Determine proper IBC settings for genesis/migration #102

iramiller opened this issue Feb 24, 2021 · 0 comments · Fixed by #207
Assignees
@iramiller
Labels
bug Something isn't working CI Continuous Integration and release process CLI Command line interface feature
Projects
Mainnet
Milestone
1.0.0

Comments

@iramiller
Copy link
Member

Summary of Bug

Currently the default values for IBC have not been set. Determine proper values to use and set them in init, export/import commands

Remediation

  • Determine intended default IBC settings
  • Within the internal/legacy/v40/migrate.go#L241 set approprate values for IBC modules
  • For the init command that generates a new genesis file set proper default values for IBC

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added the bug Something isn't working label Feb 24, 2021
@iramiller iramiller added this to the 1.0.0 milestone Feb 24, 2021
@iramiller iramiller mentioned this issue Feb 24, 2021
Merged
8 tasks
@iramiller iramiller added CI Continuous Integration and release process CLI Command line interface feature labels Feb 25, 2021
@iramiller iramiller added this to Triage in Mainnet via automation Mar 2, 2021
@iramiller iramiller moved this from Triage to To Do in Mainnet Mar 2, 2021
@iramiller iramiller moved this from To Do to In Progress in Mainnet Mar 26, 2021
@iramiller iramiller self-assigned this Mar 26, 2021
@iramiller iramiller mentioned this issue Mar 26, 2021
Merged
8 tasks
Mainnet automation moved this from In Progress to Done Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iramiller iramiller

Labels
bug Something isn't working CI Continuous Integration and release process CLI Command line interface feature
Projects
Provenance Core Protocol Team
Archived in project
Mainnet
  
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

set ibc params in migration script for v039 chains provenance-io/provenance
1 participant
@iramiller