Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update third party proto files #391

Closed
6 tasks
iramiller opened this issue Jul 27, 2021 · 0 comments · Fixed by #393
Closed
6 tasks

Update third party proto files #391

iramiller opened this issue Jul 27, 2021 · 0 comments · Fixed by #393
Assignees
@fkneeland-figure
Labels
CI Continuous Integration and release process dependencies Pull requests that update a dependency file good first issue Good for newcomers
Milestone
v1.7.0

Comments

@iramiller
Copy link
Member

Summary

As part of updating to 0.43 of the Cosmos SDK the third party proto definitions also should be reviewed and updated as needed

Problem Definition

The third party proto files are stored in the provenance repository as canonical versions for build dependencies. These files are managed using a make proto-update-deps target. The referenced sources must be updated when the SDK is updated.

Proposal

  • Review the target sources for the third party proto files and update as required to versions that match the 0.43 Cosmos SDK.
  • Execute the target and commit resulting proto files.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added good first issue Good for newcomers CI Continuous Integration and release process dependencies Pull requests that update a dependency file labels Jul 27, 2021
@iramiller iramiller added this to the v1.6.0 milestone Jul 27, 2021
@fkneeland-figure fkneeland-figure self-assigned this Jul 27, 2021
@fkneeland-figure fkneeland-figure mentioned this issue Jul 27, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkneeland-figure fkneeland-figure

Labels
CI Continuous Integration and release process dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

Update third party proto files provenance-io/provenance
2 participants
@iramiller @fkneeland-figure