Update wasmvm dependencies and update Dockerfile for localnet #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfile to use the correct libs from wasmvm. Also fixed a kafka issue for M1s in the Dockerfile.
Taztingo
requested review from
iramiller,
channa-figure,
dwedul-figure,
arnabmitra,
derekadams and
egaxhaj
as code owners
iramiller
reviewed
May 10, 2022
derekadams
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The go.mod file was updated to use the latest version of wasmvm. The main reason for this update is to get the prebuilt aarch64 wasmvm libraries, which are needed by our localnet Dockerfile. Additionally, the Dockerfile was updated to incorporate these new libraries.
A M1 kafka issue was found, and a fix was added to install the needed dependencies on M1 machines.
closes: #817
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes