Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modify name proposal #1266

Merged
merged 33 commits into from
Jan 19, 2023
Merged

Add modify name proposal #1266

merged 33 commits into from
Jan 19, 2023

Conversation

Taztingo
Copy link
Contributor

Description

Add a proposal to modify the name and restricted flag of a name.

closes: #1004


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1266 (330179e) into main (c806d5a) will decrease coverage by 0.14%.
The diff coverage is 50.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   59.08%   58.95%   -0.14%     
==========================================
  Files         196      196              
  Lines       24497    24633     +136     
==========================================
+ Hits        14475    14523      +48     
- Misses       8945     9020      +75     
- Partials     1077     1090      +13     
Impacted Files Coverage Δ
app/app.go 87.01% <ø> (ø)
x/name/keeper/msg_server.go 1.62% <0.00%> (-0.28%) ⬇️
x/name/simulation/genesis.go 0.00% <0.00%> (ø)
x/name/types/codec.go 0.00% <0.00%> (ø)
x/name/types/events.go 0.00% <0.00%> (ø)
x/name/types/msgs.go 0.00% <0.00%> (ø)
x/name/types/proposal.go 67.50% <ø> (-32.50%) ⬇️
x/name/keeper/keeper.go 77.14% <63.63%> (-1.78%) ⬇️
x/name/client/cli/tx.go 67.71% <69.84%> (+1.04%) ⬆️
x/name/client/cli/gov.go 77.21% <100.00%> (ø)
... and 3 more

@Taztingo Taztingo marked this pull request as ready for review December 15, 2022 20:57
@Taztingo Taztingo requested a review from a team as a code owner December 15, 2022 20:57
Copy link
Contributor

@SpicyLemon SpicyLemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, but mostly looks good.

x/name/client/cli/gov.go Outdated Show resolved Hide resolved
proto/provenance/name/v1/name.proto Outdated Show resolved Hide resolved
x/name/client/cli/gov.go Outdated Show resolved Hide resolved
x/name/client/cli/gov.go Outdated Show resolved Hide resolved
x/name/spec/04_events.md Outdated Show resolved Hide resolved
…rences to it. Removed unused code. Added comments to protos. Updated events to include missing proposal.
@llama-del-rey
Copy link
Contributor

@Taztingo a question on this.. i know this way of handling proposals is probably done to keep things streamlined but in 0.46, cosmos introduced msg based gov proposals. Wondering if we are increasing the future work.

llama-del-rey
llama-del-rey previously approved these changes Jan 11, 2023
Copy link
Contributor

@llama-del-rey llama-del-rey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taztingo Taztingo mentioned this pull request Jan 11, 2023
8 tasks
x/name/types/msgs.go Outdated Show resolved Hide resolved
@Taztingo Taztingo enabled auto-merge (squash) January 18, 2023 21:36
derekadams
derekadams previously approved these changes Jan 18, 2023
Copy link
Contributor

@derekadams derekadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taztingo Taztingo enabled auto-merge (squash) January 19, 2023 16:29
@Taztingo Taztingo merged commit 0f2c7ab into main Jan 19, 2023
@Taztingo Taztingo deleted the taztingo/1004-name-proposal branch January 19, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name Module Modifications via Governance Proposal
6 participants