-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modify name proposal #1266
Add modify name proposal #1266
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
- Coverage 59.08% 58.95% -0.14%
==========================================
Files 196 196
Lines 24497 24633 +136
==========================================
+ Hits 14475 14523 +48
- Misses 8945 9020 +75
- Partials 1077 1090 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, but mostly looks good.
…rences to it. Removed unused code. Added comments to protos. Updated events to include missing proposal.
@Taztingo a question on this.. i know this way of handling proposals is probably done to keep things streamlined but in 0.46, cosmos introduced msg based gov proposals. Wondering if we are increasing the future work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add a proposal to modify the name and restricted flag of a name.
closes: #1004
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes