Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign port 9091 for ibcnet ibc1 to allow reaching grpc #1314

Conversation

tbrooks-figure
Copy link
Contributor

Description

Add a port forward for the ibc1 docker container to allow reaching its grpc port. This is intended to better allow testing for apps that need to talk to both a private and public zone directly.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tbrooks-figure tbrooks-figure requested a review from a team as a code owner January 20, 2023 17:35
derekadams
derekadams previously approved these changes Jan 20, 2023
Taztingo
Taztingo previously approved these changes Jan 20, 2023
arnabmitra
arnabmitra previously approved these changes Jan 23, 2023
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this item need a change log?

@nullpointer0x00 nullpointer0x00 merged commit 209cf3b into provenance-io:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants