-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cosmos-sdk to v0.46.8-pio-1 (from v0.46.7-pio-1) #1317
Conversation
…ot sure there are any, but better safe than sorry), and adds the quarantine and sanction modules.
…ction and quarantine modules incur a little extra gas on sends.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
- Coverage 58.95% 58.94% -0.01%
==========================================
Files 196 196
Lines 24636 24676 +40
==========================================
+ Hits 14523 14546 +23
- Misses 9022 9037 +15
- Partials 1091 1093 +2
|
…ispatch an empty message from no account and panics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add #1303 to the change log as well? I double checked the tag v0.46.8-pio-1
and those changes are in there.
A couple marker sims failed with this bump, both in the marker module. Both ended up being the randomizer providing values differently resulting in situations the sims didn't properly handle. In In Both of these were just issues with the setup of each sim and not an indication of a larger problem. |
That was a change that only involved the SDK, and it's listed in the SDKs changes. The reason the sanction and quarantine modules are listed in the changelog here is because there were changes in this repo needed in order to add them. |
closes: #1303 |
Description
This PR:
v0.46.8-pio-1
(fromv0.46.7-pio-1
).x/sanction
module.x/quarantine
module.paua
(andpaua-rc1
) upgrade handlers.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes