Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cosmos-sdk to v0.46.8-pio-1 (from v0.46.7-pio-1) #1317

Merged
merged 16 commits into from
Jan 30, 2023

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Jan 25, 2023

Description

This PR:

  1. Bumps cosmos-sdk to v0.46.8-pio-1 (from v0.46.7-pio-1).
  2. Adds the x/sanction module.
  3. Adds the x/quarantine module.
  4. Creates the paua (and paua-rc1) upgrade handlers.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner January 25, 2023 21:39
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #1317 (356c413) into main (e4a52fb) will decrease coverage by 0.01%.
The diff coverage is 61.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
- Coverage   58.95%   58.94%   -0.01%     
==========================================
  Files         196      196              
  Lines       24636    24676      +40     
==========================================
+ Hits        14523    14546      +23     
- Misses       9022     9037      +15     
- Partials     1091     1093       +2     
Impacted Files Coverage Δ
app/upgrades.go 6.14% <0.00%> (-3.48%) ⬇️
x/marker/simulation/operations.go 75.96% <0.00%> (-1.33%) ⬇️
app/app.go 87.51% <100.00%> (+0.50%) ⬆️

Copy link
Contributor

@nullpointer0x00 nullpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add #1303 to the change log as well? I double checked the tag v0.46.8-pio-1 and those changes are in there.

@SpicyLemon
Copy link
Contributor Author

A couple marker sims failed with this bump, both in the marker module. Both ended up being the randomizer providing values differently resulting in situations the sims didn't properly handle.

In SimulateMsgChangeStatus, randomMarker started returning a marker with in StatusDestroyed. The switch didn't account for it, so an attempt was being made to Dispatch nothing. It resulted in a panic calling account.GetAddress() because account is nil because there's no address for it to try to find.

In provwasm simulations (specifically in SimulateMsgExecuteContract), the funds being provided in the message weren't being taken into account when getting the random fee amount. This resulted in a message trying to use more funds than were available in the account.

Both of these were just issues with the setup of each sim and not an indication of a larger problem.

@SpicyLemon
Copy link
Contributor Author

Can we add #1303 to the change log as well? I double checked the tag v0.46.8-pio-1 and those changes are in there.

That was a change that only involved the SDK, and it's listed in the SDKs changes.

The reason the sanction and quarantine modules are listed in the changelog here is because there were changes in this repo needed in order to add them.

@SpicyLemon
Copy link
Contributor Author

SpicyLemon commented Jan 27, 2023

closes: #1303

@SpicyLemon SpicyLemon mentioned this pull request Jan 30, 2023
8 tasks
@SpicyLemon SpicyLemon enabled auto-merge (squash) January 30, 2023 18:47
@SpicyLemon SpicyLemon merged commit 227f59b into main Jan 30, 2023
@SpicyLemon SpicyLemon deleted the dwedul/bump-sdk-to-v0.46.8-pio-1 branch January 30, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants