Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max commissions in paua upgrade #1333

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Feb 1, 2023

Description

Update the paua and paua-rc1 upgrades to bump all validator's max commission to 100%.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon marked this pull request as ready for review February 1, 2023 23:31
@SpicyLemon SpicyLemon requested a review from a team as a code owner February 1, 2023 23:31
@SpicyLemon SpicyLemon changed the title Dwedul/increase max commissions Increase max commissions in paua upgrade Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #1333 (2126c4e) into main (4de3528) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
- Coverage   59.02%   59.00%   -0.03%     
==========================================
  Files         196      196              
  Lines       24719    24729      +10     
==========================================
  Hits        14591    14591              
- Misses       9036     9046      +10     
  Partials     1092     1092              
Impacted Files Coverage Δ
app/upgrades.go 5.64% <0.00%> (-0.50%) ⬇️

@SpicyLemon SpicyLemon merged commit bfb3b38 into main Feb 2, 2023
@SpicyLemon SpicyLemon deleted the dwedul/increase-max-commissions branch February 2, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants