Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cosmos to v0.46.8-pio-2 with State Listening support #1334

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

egaxhaj
Copy link
Contributor

@egaxhaj egaxhaj commented Feb 1, 2023

Description

  • bumps Cosmos SDK to v0.46.8-pio-2
  • adds State Listening support
  • updates third_party proto files from v0.46.8-pio-2

closes: #1332


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egaxhaj egaxhaj requested a review from a team as a code owner February 1, 2023 23:44
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1334 (2d2e89c) into main (bb9dcfe) will decrease coverage by 0.03%.
The diff coverage is 28.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
- Coverage   58.93%   58.90%   -0.03%     
==========================================
  Files         197      197              
  Lines       24783    24804      +21     
==========================================
+ Hits        14606    14612       +6     
- Misses       9085     9099      +14     
- Partials     1092     1093       +1     
Impacted Files Coverage Δ
app/app.go 85.71% <28.57%> (-1.81%) ⬇️

SpicyLemon
SpicyLemon previously approved these changes Feb 2, 2023
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Just found one issue with a comment being incorrect. Once corrected I'm ready to approve.

nullpointer0x00
nullpointer0x00 previously approved these changes Feb 2, 2023
Copy link
Contributor

@derekadams derekadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpicyLemon SpicyLemon enabled auto-merge (squash) February 2, 2023 18:49
@SpicyLemon SpicyLemon merged commit e60224c into main Feb 2, 2023
@iramiller iramiller deleted the 1332-bump-cosmos-to-v0.46.8-pio-2 branch May 16, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade provenance to use our Cosmos fork version v0.46.8-pio-2
4 participants