Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the paua upgrades to set the sanction params. #1345

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Feb 3, 2023

Description

Update the paua-rc1 and paua upgrades to set the sanction module's params.

Immediate sanction and unsanction require a 1,000,000 hash deposit.

This PR also updates the paua (mainnet) upgrade to NOT increase the max gas per block. That increase is still in the paua-rc1 upgrade though.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner February 3, 2023 19:48
nullpointer0x00
nullpointer0x00 previously approved these changes Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1345 (8bb0354) into main (ba471f7) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
- Coverage   58.92%   58.87%   -0.06%     
==========================================
  Files         197      197              
  Lines       24844    24867      +23     
==========================================
  Hits        14640    14640              
- Misses       9110     9133      +23     
  Partials     1094     1094              
Impacted Files Coverage Δ
app/upgrades.go 4.54% <0.00%> (-0.80%) ⬇️

@SpicyLemon
Copy link
Contributor Author

Had to tweak it. RunMigrations needs to happen before trying to set the params for the newly added module.

@SpicyLemon
Copy link
Contributor Author

SpicyLemon commented Feb 6, 2023

I've tested this on a local chain (e.g. make run) from v1.13.1 and it works as expected.

@SpicyLemon SpicyLemon merged commit ea93595 into main Feb 6, 2023
@SpicyLemon SpicyLemon deleted the dwedul/set-sanction-params branch February 6, 2023 18:14
SpicyLemon added a commit that referenced this pull request Feb 6, 2023
* Update the paua upgrades to set the sanction params.

* Run the migrations before attempting to set the sanciton params.

* Fix lint errors about reuse of err.

* Remove duplicated piece that I forgot to replace earlier.

* Run migrations first in the upgrade.

* Don't increase max gas in paua (mainnet), at least for now.
iramiller added a commit that referenced this pull request Feb 6, 2023
* Update the paua upgrades to set the sanction params.

* Run the migrations before attempting to set the sanciton params.

* Fix lint errors about reuse of err.

* Remove duplicated piece that I forgot to replace earlier.

* Run migrations first in the upgrade.

* Don't increase max gas in paua (mainnet), at least for now.

Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants