Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tendermint to Notional's v0.34.25 (from base repo's v0.34.24) #1348

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Feb 6, 2023

Description

Address GHSA-cpqw-5g6w-h8rr:

  • Bump tendermint to Notional's v0.34.25 (from base repo's v0.34.24).
  • Bump cosmos SDK to v0.46.8-pio-3 (from v0.46.8-pio-2).

Also:

  • Remove the replace directive for confio/ics23/go v0.8.0 since v0.9.0 is out with the fix that v0.8.0 had.
  • Update the proto-update-deps.sh script to once again look up the used version of confio/ics23/go when getting the current protos.
  • Update the third-party protos.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

…mint with notional's v0.34.25 (was base repo's v0.34.24). Remove the confio/ics23/go replace since it's not needed anymore.
…cs23/go (go back to getting the version from go).
@SpicyLemon SpicyLemon requested a review from a team as a code owner February 6, 2023 18:21
@SpicyLemon SpicyLemon merged commit 4a307ed into main Feb 6, 2023
@SpicyLemon SpicyLemon deleted the dwedul/bump-tm branch February 6, 2023 18:40
SpicyLemon added a commit that referenced this pull request Feb 6, 2023
…1348)

* Bump cosmos-SDK to v0.46.8-pio-3 (from v0.46.8-pio-2). Replace tendermint with notional's v0.34.25 (was base repo's v0.34.24). Remove the confio/ics23/go replace since it's not needed anymore.

* Put scripts/proto-update-deps.sh back to the way it was with confio/ics23/go (go back to getting the version from go).

* make proto-update-deps.

* Add changelog entry.

* Add PR links to the changelog.
iramiller pushed a commit that referenced this pull request Feb 6, 2023
…1348) (#1351)

* Bump cosmos-SDK to v0.46.8-pio-3 (from v0.46.8-pio-2). Replace tendermint with notional's v0.34.25 (was base repo's v0.34.24). Remove the confio/ics23/go replace since it's not needed anymore.

* Put scripts/proto-update-deps.sh back to the way it was with confio/ics23/go (go back to getting the version from go).

* make proto-update-deps.

* Add changelog entry.

* Add PR links to the changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants