In paua, increase validators' commission max change rates to 5% #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iramiller
approved these changes
Feb 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
- Coverage 58.81% 58.80% -0.02%
==========================================
Files 197 197
Lines 24890 24896 +6
==========================================
Hits 14640 14640
- Misses 9156 9162 +6
Partials 1094 1094
|
SpicyLemon
added a commit
that referenced
this pull request
Feb 13, 2023
* Update IncreaseMaxCommissions to also bump the max change rate to 5% (if less than that). * Tweak the new comment a bit. * Add changelog line and tweak a couple existing changelog entries.
Merged
8 tasks
SpicyLemon
added a commit
that referenced
this pull request
Feb 15, 2023
… (#1362) * Update IncreaseMaxCommissions to also bump the max change rate to 5% (if less than that). * Tweak the new comment a bit. * Add changelog line and tweak a couple existing changelog entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase each validator's max commission change rate to 5% (if it's currently less than that).
Note: Even though this is technically being added to both
pauaandpaua-rc1upgrades, it's unlikely that we will cut a new softwarercbefore thepaua-rc1upgrade is performed ontestnet. That means that this change will not be applied totestnet, but will be applied during thepauaupgrade onmainnet.As of writing this,
testnethas 6 validators. 5/6 of them have a max change rate of 100%. The other validator has a max change rate of 1% (validator-us-west1-0). But it'stestnetand I figure we don't care that much about commission stuff on there.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes