-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mac binary release artifact. #1367
Conversation
Since the Here's some notes about what's changing and what it means:
So, long story short (too late!), the other parts of the release process should still behave as expected. |
Here's some details on what used to happen (before this PR):
There are four secrets defined in our Github repo that are used in the signing/notarization process. I'm not entirely sure where they come from or how they're used, so this part is a bit of a guess.
Here's an example run of the workflow before these changes: https://github.com/provenance-io/provenance/actions/runs/4108004509 Import Code-Signing Certificates
Sign the mac binaries with Gon
Fix zip structure for cosmovisor
|
* Stop signing the mac binary, and stop including it in the release artifacts. * Add changelog entry.
Description
This PR updates the release github action. The mac binary will no longer be signed, and it will no longer be part of the release artifacts or upgrade plan.
Reasons for this change:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes