Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.18 upgrade handler #1756

Merged
merged 3 commits into from Nov 20, 2023
Merged

Add 1.18 upgrade handler #1756

merged 3 commits into from Nov 20, 2023

Conversation

Taztingo
Copy link
Contributor

Description

Adds the upgrade handler for 1.18.

closes: #1755


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo marked this pull request as ready for review November 20, 2023 14:03
@Taztingo Taztingo requested a review from a team as a code owner November 20, 2023 14:03
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #1756 (e94ef04) into main (881cb7a) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 57.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
- Coverage   72.92%   72.92%   -0.01%     
==========================================
  Files         289      289              
  Lines       42240    42254      +14     
==========================================
+ Hits        30805    30813       +8     
- Misses      10077    10081       +4     
- Partials     1358     1360       +2     
Files Coverage Δ
app/upgrades.go 64.16% <57.14%> (-0.36%) ⬇️

Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tourmaline, nice.

@Taztingo Taztingo merged commit 9d436b6 into main Nov 20, 2023
39 of 40 checks passed
@Taztingo Taztingo deleted the taztingo/1755-upgrade-handler branch November 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.18 Upgrade Handler
3 participants