Update msg-fees param nhash per mil to 40,000,000 ($0.025/hash). #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0,000 = -bash.025/hash (currently 25,000,000 = -bash.04/hash).
…ersion formulas too.
…egations log entries.
…alidatorDelegations.
SpicyLemon
changed the title
|
A changelog entry is needed. |
Oops! Fixed now. Thanks! |
Taztingo
previously approved these changes
Feb 7, 2024
nullpointer0x00
previously approved these changes
Feb 9, 2024
# Conflicts: # CHANGELOG.md # client/docs/statik/statik.go
SpicyLemon
dismissed stale reviews from nullpointer0x00 and Taztingo
via
c1492e6
Taztingo
previously approved these changes
Feb 9, 2024
Taztingo
approved these changes
Feb 9, 2024
iramiller
approved these changes
Feb 9, 2024
SpicyLemon
added a commit
that referenced
this pull request
Feb 21, 2024
* In the tourmaline upgrade, update the msg-fees nhash/usd-mil to 40,000,000 = -bash.025/hash (currently 25,000,000 = -bash.04/hash). * Update the comments on the MsgFees Params message to include the conversion formulas too. * Update TestTourmaline to check for module migrations and inactive delegations log entries. * Fix capitalization and punctuation of log messages in removeInactiveValidatorDelegations. * Add punctuation to the log messages from convertNavUnits and add a done message. * Add changelog entry.
SpicyLemon
added a commit
that referenced
this pull request
Feb 22, 2024
…per-usd-mil), 1835 (transfer agents), 1843 (bid prices), 1846 (restricted coins/fee collector), 1848 (sdk to v0.46.13-pio-3). (#1849) * Require new force_transfer access to do forced transfers. (#1831) * [1829]: Add ACCESS_FORCE_TRANSFER entry to the Access enum. * [1829]: Add some clarifications to the access entries. * [1829]: Check the new force-transfer permission when doing a forced transfer. * [1829]: Add changelog entry. * [1892]: Clarify the deposit and withdraw permissions a bit. * Add exchange commitments to CLI. (#1830) * [1789]: Update cli for existing stuff that got some new fields. * [1789]: Create the commit-funds command and the helper stuff for AccountAmount and NetAssetPrice entries. * [1789]: Write the market-commitment-settle command. * [1789]: Create the market-release-commitments command. * [1789]: Create the market-accepting-commitments command. * [1789]: Create the gov-close-market command. * [1789]: Fix the placement of the accepting-orders stuff. * [1789]: Create the market-intermediary-denom command. * [1789]: Add a test helper to check if some events are in another list of events. * [1789]: Unit tests on the commit funds command. * [1789]: Add TODOs for the query commands. * [1789]: Write all the query commands. * [1789]: Unit tests on the rest of the cmd setups/makers. * [1789]: Allow providing the commitment settlement as a file. * [1789]: Unit tests on the query commands. Alter the commitment settlement fee calc setup to not require an admin arg when --file is provided. * [1789]: Unit tests on the tx commands. * [1789]: Add changelog entry. * [1789]: Fix --inputs and --outputs flag description. * [1789]: Add some flags missing from the market settle setup test case. * [1789]: A couple small tweaks to the cli tests. * Update msg-fees param nhash per mil to 40,000,000 ($0.025/hash). (#1833) * In the tourmaline upgrade, update the msg-fees nhash/usd-mil to 40,000,000 = -bash.025/hash (currently 25,000,000 = -bash.04/hash). * Update the comments on the MsgFees Params message to include the conversion formulas too. * Update TestTourmaline to check for module migrations and inactive delegations log entries. * Fix capitalization and punctuation of log messages in removeInactiveValidatorDelegations. * Add punctuation to the log messages from convertNavUnits and add a done message. * Add changelog entry. * Allow bid order prices to not be evenly divisible by buyer settlement fee ratios. (#1843) * Allow the bid price to not be evenly applicable to a fee ratio. * Fix unit tests that broke because we loosened the bid order fee/price stuff. * Add changelog entry. * Update spec docs. * Allow transfer agents to do exchange settlements with restricted coins. (#1835) * [1834]: Add tourmaline-rc2 upgrade handler since I'm about to make a state-breaking change that'll require an upgrade. * [1834]: Add context functions for passing in the transfer agent. * [1834]: Pay attention to the newly available transfer agent in the send restriction. Move the deposit check to SendRestrictionFn (from validateSendDenom) since don't need to repeat that check for every denom. Add a check for withdraw on the from addr since that might now be a marker account. Tweak a couple error messages to distinguish them from eachother. In the transfer endpoint, if the destination is also a marker, check for deposit access on that marker. * [1834]: Switch the TestAccountKeeperMintBurnCoins fix to provide the transfer agent instead of just bypassing the send restrictions. * [1834]: If no force transfer, and coming from a marker, make sure the admin has withdraw on that marker. Unit tests on the TransferCoin function. * [1834]: Unit tests on the send restriction function. * [1834]: Set the transfer agent in the exchange stuff that does bank stuff. * [1834]: Fix the unit tests that broke and add a couple new ones. * [1834]: tiny tweak to a couple unit tests. * [1834]: In AddSetNetAssetValues, emit the nav event even when the price denom's marker isn't found. * [1834]: Tweak TestKeeper_WithdrawMarketFunds again to make it a little easier on test setup. * [1834]: lint (kind of since it's in a test file that isn't linted, but whatever). * [1834]: Add access validator functions to the marker to standardize the errors when an address doesn't have a certain role. * [1834]: Remove redundant 'access' from error about not having access (the enum name starts with ACCESS_). * [1834]: Standardize the no-access errors. In WithdrawCoins, if going to a marker, make sure they've got deposit on that marker. Require a marker to be active in ordr to send its funds. * [1834]: Update TransferCoin. Add comment above authzHandler with the reason we don't check for withdraw and remove the check for withdraw. * [1834]: Fix the error in validateSendDenom for sends to a marker to reference the correct denom and address. * [1834]: Fix the tests that broke because I changed the error messages. * [1834]: Update AddSetNetAssetValues. Try all entries even if an earlier one has an error. If the price marker does not exist, only emit the event if the nav is valid. Put some unit tests on that thing. * [1834]: Add unit test on send restriction when we can't get attributes. * [1834]: Fix some comments in the mocks, add a unit test making sure force-transfer access is ignored in the send restriction, and add force transfer to a couple access unit tests. * [1834]: Update marker spec docs with all the recent chagnes. * [1834]: For the exchange stuff, pay attention to blocked addresses in the off-chance one gets used. * [1834]: Check that a marker is active before allowing a transfer. * [1834]: In WithdrawCoins, make sure the recipient is not a bank blocked address. * [1834]: Some tweaks to the spec docs to fix some typos, grammer, and flowchart stuff. * [1834]: Redo the flows so that denied is on the left for all of them. Add some links between flows. * [1834]: Fix the names of a bunch of keeper unit tests that claim to be testing account stuff. * [1834]: Unit tests on WithdrawCoins and on Transfer of non-active coins. * [1834]: Fix unit tests on WithdrawMarketFunds that broke because a call to BlockedAddr is now being made that wasn't expected previously. Add test for when the address is blocked. * [1834]: Fix TestKeeper_SettleCommitments that broke because of the added calls to BlockedAddr that weren't previously expected. * [1834]: Fix TestKeeper_DoTransfer that broke because we added calls to BlockedAddr that weren't listed as expected. Add a test for when an address is blocked. * [1834]: Fix TestKeeper_SettleOrders that broke when I added calls to BlockedAddr. * [1834]: Fix the FillAsks and FillBids unit tests that broke when I started calling BlockedAddr. * [1834]: Remove TODO that's TODONE (unit tests on blocked addresses). * [1834]: Update the exchange spec docs to include stuff about the transfer agent as well as a commitment settlement fee calc example. * [1834]: Add changelog entries. * Prevent restricted coins from ending up in the fee collector account. (#1846) * [1845]: Update the marker SendRestrictionFn to not allow restricted coins to be sent to the fee collector account. * [1845]: Add changelog entry. * [1845]: Fix some exchange unit tests that broke because they were using restricted coins for the fees. * [1845]: Update marker spec doc flowcharts. * Bump cosmos-sdk to v0.46.13-pio-3 (from v0.46.13-pio-2). (#1848) * Bump cosmos-sdk to v0.46.13-pio-3 (from v0.46.13-pio-2). * Add changelog entry. # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
I didn't put the msg-fees params update in an rc upgrade because: 1. We can easily update the params in testnet to match this, and 2. We don't (yet) need a
tourmaline-rc2, and I'd rather not make us do another testnet upgrade if we don't really need to.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes