feat: add toast message template for tx revert exception #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for truthpost ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
0xferit
approved these changes
May 19, 2023
| return "Failed to execute transaction"; | ||
| }, | ||
| }, | ||
| }, | ||
| // add more message types here as needed | ||
| }; | ||
|
|
||
| const TxRevertMessage = ({ errorMessage }) => { |
There was a problem hiding this comment.
Could we generalize this so it works for success messages as well? And do you think it would be good?
There was a problem hiding this comment.
Certainly! There is a lot of room for improving this layer. I was going to address your suggestion in #128 issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.