upgrade to persistent 2.5 #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably try to combine these two? #134 |
|
👍 i'll wait for #134 to land and then rebase? |
ilovezfs
added a commit
to ilovezfs/git-annex
that referenced
this pull request
Jul 22, 2016
aws 0.14.0 is incompatible with http-conduit 2.2.0 aristidb/aws#206 esqueleto 2.4.3 is incompatible with persistent 2.5 prowdsponsor/esqueleto#137 prowdsponsor/esqueleto#141 prowdsponsor/esqueleto#139 Solver needs these hints when building git-annex with +S3 and +Webapp.
|
Is this on purpose? |
|
I think #144 is the preferred version of this PR. |
|
yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent 2.5 introduces a backwards-incompatible change with how backends are constrained. I wasn't sure how y'all wanted to deal with this (
-XCPP?), but this patch does the dumb thing by yanking the lower bound inesqueleto.cabaltopersistent >= 2.5 && < 2.6.issue #137