Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Failing cloudformation_outputs_find_secrets due to uuids created by set.dev #1969

Closed
akunap2 opened this issue Feb 24, 2023 · 3 comments
Labels
bug severity/informational Cosmetic or nice-to-have.

Comments

@akunap2
Copy link

akunap2 commented Feb 24, 2023

What happened?
We use sst.dev to configure and deploy our Cloudformation stacks. Therefore our Cloudformation stack outputs contain metadata used by SST which contains multiple uuids. These uuids are being detected as secrets even though they are not secrets.

How to reproduce it
Steps to reproduce the behavior:

  1. What command are you running?
    Use sst.dev to deploy your application to AWS.

run:
prowler aws --checks cloudformation_outputs_find_secrets

  1. Cloud provider you are launching
    AWS

  2. See the above checks failing.

Expected behavior
These checks should pass as there are no actual secrets being passed in. After looking more into the issues, it looks like Prowler is flagging uuids created by sst.dev in the process of deploying the application to AWS as secrets. Is there a way to mark this as non secrets?

From where are you running Prowler?
Please, complete the following information:

  • Resource: CloudFormation & Lambda
  • OS: Mac
  • Prowler Version [prowler --version]: 3.1.4
  • Python version [python --version]: 3.9.6
  • Pip version [pip --version]: 23.0
  • Installation method (Are you running it from pip package or cloning the github repo?): pip package
  • Others:
@akunap2 akunap2 added bug status/needs-triage Issue pending triage labels Feb 24, 2023
@akunap2 akunap2 changed the title [Bug]: Failing cloudformation_outputs_find_secrets & awslambda_function_no_secrets_in_variables due to uuids created by set.dev [Bug]: Failing cloudformation_outputs_find_secrets due to uuids created by set.dev Feb 24, 2023
@JeffreySouza
Copy link
Contributor

JeffreySouza commented Feb 26, 2023

I think you will want to make an issue in the detect_secrets repo (example) and provide an example of what the flagged UUID looks like

@n4ch04 n4ch04 added severity/informational Cosmetic or nice-to-have. and removed status/needs-triage Issue pending triage labels Feb 27, 2023
@n4ch04
Copy link
Contributor

n4ch04 commented Feb 27, 2023

Hi @akunap2, as @JeffreySouza points Prowler use detect_secrets to look for secrets into source code, to avoid getting those results as FAILS we recommend you to whitelist that resources for that check

@n4ch04
Copy link
Contributor

n4ch04 commented Mar 1, 2023

Hi @akunap2 since it is not an issue from Prowler, we are going to close this.
Feel free to reopen if there is another problem.

Thanks for using Prowler !!

@n4ch04 n4ch04 closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity/informational Cosmetic or nice-to-have.
Projects
None yet
Development

No branches or pull requests

3 participants